TOURNAMENT -- SHINE A LIGHT ON NF.

To shine some light on the bugs we had. :)

1) Initially we downloaded the api key for one player, then all his reports, then did the same for the next player. Problem: If player B is on a spot before player A but we downloaded player A first this caused problems in the database. The fix was to first download all API keys for all players and then start with the oldest available report.
2) Some of you noticed this bug. There was an enemy army already on a spot. You sent a larger occupation army, defeated the enemy but the script was not giving making you the new occupier. The reason for this was: Both you and the defender provided battle reports for this battle. However in the case when we read the defenders reports before that of the attacker the attackers occupation time was not counted. This is because the defenders reports says that the attacker send an army with the 'Occupy' command but it does not state the occupation time. Only the report of the attacker states the occupation time. The fix was to mark the defenders report as incomplete in our database so that the report from the attacker can provide the occupation times.
3) You may have seen that on some squares the occupation times were abnormally high. EG some alliances were occupying a single square since 9 days although the tournament isn't even running that long. So that should be impossible. The reason is some kind of an anti-cheat system. Well, it's not really cheating.
You send an army to a spot. This arrives at 1pm. You gave your army an occupation time of 1 hour. So your army automatically leaves at 2pm. Someone else sends an army which arrives at 3pm. So the square is unoccupied between 2pm and 3pm.
The game doesn't provide a combat report or anything when an army leaves a square. This means that the player who's army left at 2pm will get credited to be at that spot until 3pm because only then another player arrives. So that player gained one hour of occupation time although he wasn't occupying the square. We tried to amend this by calculation the occupation start time + the occupation duration and then set the occupation end time accordingly.
For some reason however this caused very weird results. So for now we've disabled this system. Since all sqaures are under heated battles the chance of this happening is very low. And even if it does happen... Well, I'd say that the player just got lucky for now. :P


Edited by Digioso - 21 May 2016 at 13:11

kodabear wrote:   The code has to scan though about 14124 combat reports so it will take a bit

Outstanding 

Ah, ok thanks 

It was working well before, but now says "internal server error!"